Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service worker registration with custom protocols #34291

Merged
merged 1 commit into from May 23, 2022
Merged

fix: service worker registration with custom protocols #34291

merged 1 commit into from May 23, 2022
+50 −4

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented May 19, 2022 •
edited

Description of Change

Backport of #34290

Release Notes

Notes: fix service worker registration with custom protocols

@deepak1556 deepak1556 requested review from a team as code owners May 19, 2022 16:39
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 19, 2022
@trop trop bot mentioned this pull request May 19, 2022
Merged
@trop trop bot added 18-x-y backport This is a backport PR labels May 19, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 19, 2022
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/17-x-y labels May 19, 2022
@deepak1556 deepak1556 closed this May 23, 2022
@deepak1556 deepak1556 reopened this May 23, 2022
@codebytere codebytere added backport This is a backport PR and removed backport This is a backport PR labels May 23, 2022
@deepak1556 deepak1556 merged commit 74b85af into 18-x-y May 23, 2022
@deepak1556 deepak1556 deleted the robo/fix_sw_registration_18_x_y branch May 23, 2022 12:20
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

fix service worker registration with custom protocols

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/17-x-y label May 23, 2022
@deepak1556
Copy link
Member Author

Backport is not required for 17-x-y, PlzServiceWorker feature was enabled only since Chromium 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere