fix: revert "feat: add first-instance-ack event to the app.requestSingleInstanceLock() flow
#34295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngleInstanceLock()` flow"
VerteDinde
force-pushed
the
revert-ackpipe-18-x-y
branch
from
26c41f3
to
9d6df29
Compare
VerteDinde
added
backport-check-skip
VerteDinde
force-pushed
the
revert-ackpipe-18-x-y
branch
from
9d6df29
to
0039997
Compare
VerteDinde
force-pushed
the
revert-ackpipe-18-x-y
branch
from
0039997
to
0225b19
Compare
5 tasks
codebytere
approved these changes
May 20, 2022
deepak1556
approved these changes
May 20, 2022
|
Release Notes Persisted
|
codebytere
pushed a commit
that referenced
this pull request
May 23, 2022
…Lock() flow (#34312) fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow (#34295) * Revert "fix: requestSingleInstanceLock API ConnectNamedPipe sometimes hangs program (#33778)" This reverts commit ffb8749. * fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow" * chore: update patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #34297
See that PR for details
Notes: Fixed an issue where running second instances of the same application would cause a deadlock on Windows.