Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: WCO crash on bad titlebarStyle #34302

Merged
merged 1 commit into from May 23, 2022
Merged

fix: WCO crash on bad titlebarStyle #34302

merged 1 commit into from May 23, 2022

Conversation

codebytere
Copy link
Member

Backport of #34140.

See that PR for details.

Notes: Fixes an issue where calling setTitlebarOverlay with an initially invalid titleBarStyle on Windows would result in a crash.

@codebytere codebytere requested a review from a team May 20, 2022 20:05
@trop trop bot mentioned this pull request May 20, 2022
Merged
4 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 20, 2022
@VerteDinde
Copy link
Member

Appveyor win-woa is green, just not updated in GitHub

@VerteDinde VerteDinde merged commit c7cd23c into 19-x-y May 23, 2022
@VerteDinde VerteDinde deleted the fix-wco-titlebarstyle-crash-19 branch May 23, 2022 02:42
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

Fixes an issue where calling setTitlebarOverlay with an initially invalid titleBarStyle on Windows would result in a crash.

@ErikSin ErikSin mentioned this pull request Jan 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @VerteDinde