Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: add first-instance-ack event to the app.requestSingleInstanceLock() flow #34312

Merged
merged 1 commit into from May 23, 2022
Merged

revert: add first-instance-ack event to the app.requestSingleInstanceLock() flow #34312

merged 1 commit into from May 23, 2022

Conversation

VerteDinde
Copy link
Member

Manual backport of #34297

See that PR for details

Notes: Fixed an issue where running second instances of the same application would cause a deadlock on Windows.

@VerteDinde
fix: revert "feat: add first-instance-ack event to the `app.requestSi…
6ae0a22 
…ngleInstanceLock()` flow (#34295)

* Revert "fix: requestSingleInstanceLock API ConnectNamedPipe sometimes hangs program (#33778)"

This reverts commit ffb8749.

* fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow"

* chore: update patch
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@trop trop bot mentioned this pull request May 23, 2022
Merged
5 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/minor backwards-compatible functionality labels May 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@VerteDinde VerteDinde marked this pull request as ready for review May 23, 2022 06:41
@VerteDinde VerteDinde requested review from a team as code owners May 23, 2022 06:41
@codebytere codebytere merged commit 23c18be into 19-x-y May 23, 2022
@codebytere codebytere deleted the revert-ackpipe-19-x-y branch May 23, 2022 12:51
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

Fixed an issue where running second instances of the same application would cause a deadlock on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VerteDinde @codebytere