Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on navigator.serial.getPorts() #34328

Merged
merged 1 commit into from May 23, 2022
Merged

fix: crash on navigator.serial.getPorts() #34328

merged 1 commit into from May 23, 2022

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented May 23, 2022 •
edited

Backport of #34280

See that PR for details.

Notes: fixed crash when calling navigator.serial.getPorts()

@jkleinsc
fix: crash on navigator.serial.getPorts()
927752f 
(cherry picked from commit 7f94317)
(cherry picked from commit 1b5738e)
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@trop trop bot added 17-x-y backport This is a backport PR labels May 23, 2022
@trop trop bot mentioned this pull request May 23, 2022
Merged
4 tasks
@trop trop bot added the semver/patch backwards-compatible bug fixes label May 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 23, 2022
@jkleinsc jkleinsc merged commit 9bb03e9 into 17-x-y May 23, 2022
@jkleinsc jkleinsc deleted the fixup-serial-crash-17 branch May 23, 2022 19:11
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

fixed crash when calling navigator.serial.getPorts()

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I have automatically backported this PR to "15-x-y", please check out #34333

@trop
Copy link
Contributor

trop bot commented May 23, 2022

I have automatically backported this PR to "16-x-y", please check out #34334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @VerteDinde