fix: crash when setWindowOpenHandler callback throws
#34523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
setWindowOpenHandler callback throws
jkleinsc
approved these changes
Jun 13, 2022
VerteDinde
approved these changes
Jun 13, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "18-x-y" cleanly; |
This was referenced Jun 14, 2022
|
I have automatically backported this PR to "19-x-y", please check out #34546 |
|
I have automatically backported this PR to "20-x-y", please check out #34547 |
miniak
pushed a commit
that referenced
this pull request
Jun 19, 2022
2 tasks
zcbenz
pushed a commit
that referenced
this pull request
Jun 20, 2022
fix: crash when `setWindowOpenHandler` callback throws (#34523) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
miniak
added a commit
that referenced
this pull request
Jun 28, 2022
miniak
added a commit
that referenced
this pull request
Jun 28, 2022
VerteDinde
pushed a commit
that referenced
this pull request
Jun 29, 2022
fix: crash when `setWindowOpenHandler` callback throws (#34523)
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: crash when setWindowOpenHandler throws * refactor: throw as process uncaughtException event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34508.
Fixes an error where
setWindowOpenHandler()would crash if the callback threw an error. Fix this issue by wrapping the call in a try/catch and handling appropriately if an error is thrown.Checklist
npm testpassesRelease Notes
Notes: Fixed an error where
setWindowOpenHandler()would crash if the callback threw an error