New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make preload calculation identical between sandbox & non-sandboxed #34531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
requested changes
Jun 14, 2022
miniak
reviewed
Jun 14, 2022
miniak
reviewed
Jun 14, 2022
miniak
approved these changes
Jun 14, 2022
miniak
reviewed
Jun 15, 2022
miniak
approved these changes
Jun 15, 2022
Release Notes Persisted
|
I have automatically backported this PR to "20-x-y", please check out #34585 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This changes non-sandboxed renderers to load preload scripts the same way that
sandboxed renderers do: by sending a synchronous IPC to the main process to ask
for what preloads should be used.
This does change behavior in some cases. In particular, when running
window.open('about:blank')
from a window with a preload andnodeIntegrationInSubFrames: true
, previously the child window would inheritthe parent window's preloads, due to the fact that
about:blank
child windowsdon't go through a browser-side navigation in Chromium (see here
for further details).
Checklist
npm test
passesRelease Notes
Notes: Fixed child
about:blank
windows from inheriting their parents' preload scripts whensandbox: false
andnodeIntegrationInSubFrames: true
.