fix: WCO respects maximizable/closable/minimizable #34677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
codebytere
force-pushed
the
wco-enabling-follow
branch
from
c6eb7a0
to
308fd70
Compare
jkleinsc
approved these changes
Jun 22, 2022
zcbenz
approved these changes
Jun 23, 2022
|
Release Notes Persisted
|
This was referenced Jun 23, 2022
|
I have automatically backported this PR to "18-x-y", please check out #34720 |
|
I have automatically backported this PR to "20-x-y", please check out #34721 |
|
I have automatically backported this PR to "19-x-y", please check out #34722 |
|
/trop run backport-to 17-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "17-x-y", please check out #34733 |
3 tasks
4 tasks
5 tasks
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32285.
Adapts WCO window button container to adapt to and update based on the maximizable, minimizable, and closable states of a given BrowserWindow. It is slightly different UI-wise than native, in that it does not fully grey out when disabled, but it behaves the same.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Windows Control Overlay buttons did not respect maximizable/minimizable/closable states of a BrowserWindow.