Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential crash caused by dlopen different gtk libraries #34774

Merged
merged 1 commit into from Jun 30, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 28, 2022

Backport of #33650
Backport of #34141

See that PR for details.

Notes: fix crash when opening gtk file dialogs due to mismatched versions

@miniak miniak requested review from a team as code owners June 28, 2022 15:54
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2022
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 28, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2022
@miniak
Copy link
Contributor Author

miniak commented Jun 28, 2022

@deepak1556 can you please check? The change from E18 is slightly different than our internal backport in E17

@codebytere
Copy link
Member

codebytere commented Jun 29, 2022

@miniak gn check failed:

#!/bin/bash -eo pipefail
cd src
gn gen out/Default --args="import(\"$GN_CONFIG\") import(\"$GN_GOMA_FILE\") $GN_EXTRA_ARGS $GN_BUILDFLAG_ARGS"

ERROR Unresolved dependencies.
//electron:electron_gtk_stubs(//build/toolchain/linux:clang_arm64)
  needs //ui/gtk:gtk_config(//build/toolchain/linux:clang_arm64)


Exited with code exit status 1
CircleCI received exit code 1

@deepak1556
Copy link
Member

deepak1556 commented Jun 29, 2022

@codebytere the gn check is a weird failure, the dependency on //ui/gtk:gtk_config was replaced in commit 3c0ea37 with //build/config/linux/gtk. The failing step in the gn check run is actually before the actual check in Default GN gen which passes on other runs for the same commit.

Some kind of bad cache is causing the failure.

@jviotti
Copy link
Contributor

jviotti commented Jun 29, 2022

An interesting Linux one you might be curious about @robertgzr

@miniak miniak force-pushed the miniak/fix_gtk_loading-17-x-y branch from 3c0ea37 to 6f31ae2 Compare June 30, 2022 13:49
@VerteDinde VerteDinde merged commit 342eb67 into 17-x-y Jun 30, 2022
@VerteDinde VerteDinde deleted the miniak/fix_gtk_loading-17-x-y branch June 30, 2022 16:07
@release-clerk
Copy link

release-clerk bot commented Jun 30, 2022

Release Notes Persisted

fix crash when opening gtk file dialogs due to mismatched versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants