fix: delegate to PrintViewManagerBase on failed print
#34893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
PrintViewManagerBase on failed print
codebytere
force-pushed
the
fix-missing-invalid-settings-error
branch
from
a0503fc
to
7260c63
Compare
codebytere
force-pushed
the
fix-missing-invalid-settings-error
branch
from
7260c63
to
310a079
Compare
jkleinsc
approved these changes
Jul 19, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "20-x-y" cleanly; |
VerteDinde
pushed a commit
that referenced
this pull request
Jul 29, 2022
fix: delegate to PrintViewManagerBase on failed print
|
@VerteDinde has manually backported this PR to "20-x-y", please check out #35139 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
fix: delegate to PrintViewManagerBase on failed print
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: delegate to PrintViewManagerBase on failed print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34813.
Fixes an issue where invalid
pageSizevalues would cause a silent hang and eventual crash. This was happening because ourPrintVieeManagerwas incorrectly delegating failures back toPrintViewManagerBasefor non-headless job failures. Correct this issue by delegating when the job is a regular printer job and not a headless PDF job.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where invalid
pageSizevalues would cause a silent hang and eventual crash.