New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up callback handling in webContents.print()
#34894
Conversation
webContents.print()
a5e7518
to
debcea3
Compare
Release Notes Persisted
|
I was unable to backport this PR to "18-x-y" cleanly; |
I was unable to backport this PR to "20-x-y" cleanly; |
I was unable to backport this PR to "19-x-y" cleanly; |
@codebytere has manually backported this PR to "20-x-y", please check out #35141 |
Description of Change
Refs #34813.
Fixes an issue where invalid print job settings would correctly call back
Invalid print settings
as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit. As a side effect of this, the job success status variables have been streamlined and converted into an enum.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where invalid print job settings would correctly call back
Invalid print settings
as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit.