Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up callback handling in webContents.print() #34894

Merged
merged 2 commits into from Jul 21, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Refs #34813.

Fixes an issue where invalid print job settings would correctly call back Invalid print settings as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit. As a side effect of this, the job success status variables have been streamlined and converted into an enum.

Checklist

Release Notes

Notes: Fixed an issue where invalid print job settings would correctly call back Invalid print settings as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Jul 12, 2022
@codebytere codebytere requested review from a team as code owners July 12, 2022 13:50
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 12, 2022
@codebytere codebytere changed the title fix: clean up callback handling in webContents.print() fix: clean up callback handling in webContents.print() Jul 12, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@codebytere codebytere requested a review from jkleinsc July 19, 2022 12:56
@codebytere codebytere merged commit 1ed1911 into main Jul 21, 2022
@codebytere codebytere deleted the better-print-reason branch July 21, 2022 10:46
@release-clerk
Copy link

release-clerk bot commented Jul 21, 2022

Release Notes Persisted

Fixed an issue where invalid print job settings would correctly call back Invalid print settings as the failure reason, but would then not terminate the print job, leading to an eventual crash on exit.

@trop
Copy link
Contributor

trop bot commented Jul 21, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 21, 2022

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 21, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 29, 2022

@codebytere has manually backported this PR to "20-x-y", please check out #35141

schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
)

* refactor: clean up callback handling in webContents.print()

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
)

* refactor: clean up callback handling in webContents.print()

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants