Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules #34944

Merged
merged 1 commit into from Jul 18, 2022
Merged

fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules #34944

merged 1 commit into from Jul 18, 2022

Commits on Jul 18, 2022

  1. fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules (#… 

    …34932)

This define is only needed when linking against Chromiums libc++ which we currently
do not ship / expose the symbols of.  We probably should make those symbols visible and
actually ensure that electron-rebuild et. al link against our libc++ instead of the system libc++
but for now this fixes compilation issues on macOS where the default system clang links to the system libc++
which does not (obviously) use the Chromium ABI namespace.

For our nan tests which do link against Chromiums libc++ we define the ABI namespace in the spec runner.
    @MarshallOfSound @VerteDinde
    MarshallOfSound authored and VerteDinde committed Jul 18, 2022
    Copy the full SHA
    45bd6ff View commit details
    Browse the repository at this point in the history