Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules #34944

Merged
merged 1 commit into from Jul 18, 2022
Merged

fix: do not define _LIBCPP_ABI_NAMESPACE=Cr for all native modules #34944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion patches/node/.patches
View file
Open in desktop
Expand Up @@ -44,4 +44,3 @@ src_update_importmoduledynamically.patch
fix_add_v8_enable_reverse_jsargs_defines_in_common_gypi.patch
json_parse_errors_made_user-friendly.patch
build_ensure_v8_pointer_compression_sandbox_is_enabled_on_64bit.patch
build_define_libcpp_abi_namespace_as_cr_to_align_with_chromium.patch
21 changes: 0 additions & 21 deletions patches/node/build_define_libcpp_abi_namespace_as_cr_to_align_with_chromium.patch
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions script/nan-spec-runner.js
View file
Open in desktop
Expand Up @@ -62,6 +62,7 @@ async function main () {
`-isystem"${path.resolve(BASE, 'buildtools', 'third_party', 'libc++', 'trunk', 'include')}"`,
`-isystem"${path.resolve(BASE, 'buildtools', 'third_party', 'libc++abi', 'trunk', 'include')}"`,
'-fPIC',
'-D_LIBCPP_ABI_NAMESPACE=Cr',
...platformFlags
].join(' ');

Expand Down