New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly fire serial-port-added and serial-port-removed events #34958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It look like the tests themselves pass but then in the dtor there's a crash:
Received signal 11 <unknown> 000000000000
0 Electron Framework 0x0000000123eb0952 base::debug::CollectStackTrace(void**, unsigned long) + 18
1 Electron Framework 0x0000000123dcd413 base::debug::StackTrace::StackTrace() + 19
2 Electron Framework 0x0000000123eb08a1 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 1345
3 libsystem_platform.dylib 0x00007ff803414dfd _sigtramp + 29
4 Electron Framework 0x0000000125dbcb25 mojo::core::ports::Node::AcceptEvent(mojo::core::ports::NodeName const&, std::Cr::unique_ptr<mojo::core::ports::Event, std::Cr::default_delete<mojo::core::ports::Event>>) + 2277
5 Electron Framework 0x0000000123e22b21 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker(base::SequenceCheckerImpl const&) + 33
6 Electron Framework 0x0000000123df0e97 base::internal::WeakReference::IsValid() const + 39
7 Electron Framework 0x000000011f3e6dc8 base::ObserverList<content::SerialDelegate::Observer, false, true, base::internal::CheckedObserverAdapter>::RemoveObserver(content::SerialDelegate::Observer const*) + 104
8 Electron Framework 0x000000011f3e90d7 electron::SerialChooserController::~SerialChooserController() + 327
9 Electron Framework 0x000000011f3e566c electron::ElectronSerialDelegate::~ElectronSerialDelegate() + 124
10 Electron Framework 0x000000011f37dbce electron::ElectronBrowserClient::~ElectronBrowserClient() + 190
11 Electron Framework 0x000000011f37dc6e electron::ElectronBrowserClient::~ElectronBrowserClient() + 14
12 Electron Framework 0x000000011f27c850 ElectronMain + 192
13 dyld 0x000000010966651e start + 462
[end of stack trace]
✗ Electron tests failed with kill signal SIGSEGV.
Based on 2309652: [webhid] Notify chooser context observers on shutdown | https://chromium-review.googlesource.com/c/chromium/src/+/2309652
c4a1a66
to
dfdb74d
Compare
The crash was resolved by following an approach similar to: [webhid] Notify chooser context observers on shutdown. |
Merging as CI failure is known CI issue unrelated to this PR. |
Release Notes Persisted
|
I was unable to backport this PR to "17-x-y" cleanly; |
I was unable to backport this PR to "18-x-y" cleanly; |
I was unable to backport this PR to "19-x-y" cleanly; |
I have automatically backported this PR to "20-x-y", please check out #35047 |
…lectron#34958) Based on 2309652: [webhid] Notify chooser context observers on shutdown | https://chromium-review.googlesource.com/c/chromium/src/+/2309652
…lectron#34958) Based on 2309652: [webhid] Notify chooser context observers on shutdown | https://chromium-review.googlesource.com/c/chromium/src/+/2309652
Description of Change
Closes #34887.
Checklist
npm test
passesRelease Notes
Notes: fixed
serial-port-added
andserial-port-removed
events not firing.