Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify file extension generation on Windows #35171

Commits on Aug 2, 2022

  1. fix: modify file extension generation on Windows (#34723)

    * fix: modify file extension generation on Windows
    
    * modify includes
    
    * include vector in header
    
    * add win build flags
    
    * remove hardcoded strings
    
    * Update shell/browser/electron_download_manager_delegate.h
    
    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    
    * fix string manipulation and function definitions
    
    * Update electron_download_manager_delegate.h
    
    * convert to std::string and modify for electron
    
    * Update shell/browser/electron_download_manager_delegate.cc
    
    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    
    * remove vector include and update conversion
    
    * add vectr include for lint
    
    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    2 people authored and electron-bot committed Aug 2, 2022
    Copy the full SHA
    e7a55cb View commit details
    Browse the repository at this point in the history