fix: Node.js atob input validation
#35415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
changed the title
atob input validation
miniak
approved these changes
Aug 23, 2022
zcbenz
approved these changes
Aug 25, 2022
|
Release Notes Persisted
|
This was referenced Aug 25, 2022
|
I have automatically backported this PR to "21-x-y", please check out #35443 |
trop
bot
removed
the
target/21-x-y
|
I have automatically backported this PR to "19-x-y", please check out #35444 |
|
I have automatically backported this PR to "20-x-y", please check out #35445 |
trop
bot
added
in-flight/19-x-y
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: Node.js atob input validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31018.
Cherry-picks
atobinput validation nodejs/node#42539to fix inconsistencies between Node.js' implementation of atob and the WHATWG spec.
Checklist
npm testpassesRelease Notes
Notes: Fixed a bug where calling
atobin the renderer process could fail under some circumstances.