Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Node.js atob input validation #35444

Merged
merged 2 commits into from Sep 22, 2022
Merged

fix: Node.js atob input validation #35444

merged 2 commits into from Sep 22, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 25, 2022

Backport of #35415

See that PR for details.

Notes: Fixed a bug where calling atob in the renderer process could fail under some circumstances.

@trop trop bot requested review from a team as code owners August 25, 2022 06:55
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2022
@trop trop bot requested a review from codebytere August 25, 2022 06:56
@trop trop bot mentioned this pull request Aug 25, 2022
Merged
3 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 25, 2022
@codebytere codebytere force-pushed the trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812 branch from cfee141 to 91a1299 Compare August 25, 2022 10:21
zcbenz
zcbenz previously requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch doesn't apply.

@codebytere codebytere merged commit 7d84b3b into 19-x-y Sep 22, 2022
@codebytere codebytere deleted the trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812 branch September 22, 2022 07:54
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2022

Release Notes Persisted

Fixed a bug where calling atob in the renderer process could fail under some circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz zcbenz left review comments

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @codebytere @jkleinsc