chore: drop unresponsive suppressor for menus #35498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
changed the title
|
Wanna ensure we don't reintroduce #2947 |
|
I tested this PR on Windows 10 and was unable to reproduce #2947. |
codebytere
approved these changes
Aug 30, 2022
|
cc @zcbenz in case there's anything I missed—this code has a long heritage! |
zcbenz
reviewed
Aug 31, 2022
There was a problem hiding this comment.
The menu popup loop still runs on UI thread, #20114 didn't change that. But code had been added to allow nested tasks in menu popup loop so the unresponsive problem may have been solved by it.
I think we should still do testing on macOS.
| @@ -156,7 +155,6 @@ | |||
| base::mac::ScopedSendingEvent sendingEventScoper; | |||
|
|
|||
| // Don't emit unresponsive event when showing menu. | |||
|
I did test on macOS and wasn't able to cause an unresponsive event to happen by showing a menu. |
zcbenz
approved these changes
Aug 31, 2022
|
mac test failures are flake; merging. |
|
No Release Notes |
kyrylo-hrechykhin
pushed a commit
to kyrylo-hrechykhin/electron
that referenced
this pull request
Sep 1, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This no longer seems to be necessary since #20114 moved the menu popup loop off
the UI thread.
Checklist
npm testpassesRelease Notes
Notes: none