Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 47968ed from chromium #35530

Merged
merged 4 commits into from Sep 15, 2022
Merged

Conversation

mlaurencin
Copy link
Contributor

@mlaurencin mlaurencin commented Aug 31, 2022

Subject: dpwa: Enable Window Controls Overlay by default

This reverts commit d61c4042374672712176e43e33f39a1e66da4faa.
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/guI1QCPJTAA

Bug: 937121
Change-Id: I3dfebec2356c7a12fd7eab32f12ef8d9e4bf6ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430266
Commit-Queue: Alex Russell slightlyoff@chromium.org
Reviewed-by: Alex Russell slightlyoff@chromium.org
Reviewed-by: Avi Drissman avi@chromium.org
Cr-Commit-Position: refs/heads/main@{#1013665}


Closes #35214

main and 21-x-y are passed 105.0.5119.0 and therefore have this commit

Release Notes

Notes: Fixed an issue where a child of a window using WCO would not have the navigator defined

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2022
@mlaurencin mlaurencin added semver/minor backwards-compatible functionality backport-check-skip Skip trop's backport validity checking target/18-x-y labels Aug 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2022
@mlaurencin mlaurencin marked this pull request as ready for review September 7, 2022 17:32
@mlaurencin mlaurencin requested review from a team as code owners September 7, 2022 17:32
@codebytere codebytere merged commit cbd39f7 into 20-x-y Sep 15, 2022
@codebytere codebytere deleted the set-navigator-wco-fix branch September 15, 2022 23:21
@release-clerk
Copy link

release-clerk bot commented Sep 15, 2022

Release Notes Persisted

Fixed an issue where a child of a window using WCO would not have the navigator defined

trop bot pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Charles Kerr <charles@charleskerr.com>
@trop
Copy link
Contributor

trop bot commented Sep 15, 2022

I have automatically backported this PR to "19-x-y", please check out #35701

ckerr added a commit that referenced this pull request Sep 16, 2022
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants