Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick 47968ed from chromium #35701

Merged
merged 2 commits into from Sep 16, 2022
Merged

chore: cherry-pick 47968ed from chromium #35701

merged 2 commits into from Sep 16, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 15, 2022

Backport of #35530

See that PR for details.

Notes: Fixed an issue where a child of a window using WCO would not have the navigator defined

@trop trop bot requested review from a team as code owners September 15, 2022 23:22
@trop trop bot requested a review from mlaurencin September 15, 2022 23:22
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2022
@trop trop bot mentioned this pull request Sep 15, 2022
Merged
@trop trop bot added 19-x-y backport This is a backport PR semver/minor backwards-compatible functionality labels Sep 15, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2022
@ckerr
Copy link
Member

ckerr commented Sep 16, 2022

not ok 296 BrowserWindow module BrowserWindow.setVibrancy(type) Allows setting a transparent window via CSS

CI failure is unrelated to PR. This test was disabled in main due to flakiness in #34660

mlaurencin and others added 2 commits September 16, 2022 08:46
@mlaurencin @ckerr
chore: cherry-pick 47968ed from chromium (#35530)
37cf942 
Co-authored-by: Charles Kerr <charles@charleskerr.com>
@patchup @ckerr
chore: update patches
b869547
@ckerr ckerr force-pushed the trop/19-x-y-bp-chore-cherry-pick-47968ed-from-chromium-1663284119137 branch from 9e1fe67 to b869547 Compare September 16, 2022 15:46
@codebytere codebytere merged commit 58f7ab8 into 19-x-y Sep 16, 2022
@codebytere codebytere deleted the trop/19-x-y-bp-chore-cherry-pick-47968ed-from-chromium-1663284119137 branch September 16, 2022 18:38
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2022

Release Notes Persisted

Fixed an issue where a child of a window using WCO would not have the navigator defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckerr @codebytere @mlaurencin