fix: allow contextmenu event in draggable regions #37386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
semver/patch
This was referenced Feb 23, 2023
VerteDinde
approved these changes
Feb 23, 2023
codebytere
approved these changes
Feb 23, 2023
|
Release Notes Persisted
|
This was referenced Feb 24, 2023
|
I have automatically backported this PR to "23-x-y", please check out #37394 |
|
I have automatically backported this PR to "24-x-y", please check out #37395 |
trop
bot
added
in-flight/24-x-y
merged/24-x-y
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
3 tasks
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The change in #35603 made it so that right-click events in draggable regions
stopped being delivered to the web content, and were only delivered to the
browser. This adds some hacks to preserve that behavior, though I'm not sure
this is the best way forward. I feel like it might be better to expose
system-context-menuon macOS instead, and have right-clicks indraggable regions trigger that event.
However, that would break backwards compatibility. I'd rather only do that
intentionally, so this PR for now preserves the old behavior.
Fixes #37301.
Checklist
npm testpassesRelease Notes
Notes: Fixed right-click events not being delivered in frameless window draggable regions.