Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove workaround for fixed Menu.closePopup issue #37802

Merged
merged 1 commit into from
Apr 4, 2023

test: remove workaround for fixed Menu.closePopup issue

d3d7809
Select commit
Failed to load commit list.
Merged

test: remove workaround for fixed Menu.closePopup issue #37802

test: remove workaround for fixed Menu.closePopup issue
d3d7809
Select commit
Failed to load commit list.
trop / Backportable? - 24-x-y completed Apr 3, 2023 in 13m 23s

Backport Failed

This PR was checked and could not be automatically backported to "24-x-y" cleanly

Details

Failed Diff:

diff --cc spec/api-menu-spec.ts
index 5c47ee01f7,16c2e4b2df..0000000000
--- a/spec/api-menu-spec.ts
+++ b/spec/api-menu-spec.ts
@@@ -816,10 -817,7 +816,14 @@@ describe('Menu module', function () 
      it('should emit menu-will-close event', (done) => {
        menu.on('menu-will-close', () => { done(); });
        menu.popup({ window: w });
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue
      });
  
      it('returns immediately', () => {
@@@ -848,18 -846,12 +852,26 @@@
  
        expect(x).to.equal(100);
        expect(y).to.equal(101);
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue
      });
  
      it('works with a given BrowserWindow, no options, and a callback', (done) => {
        menu.popup({ window: w, callback: () => done() });
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue
      });
  
      it('prevents menu from getting garbage-collected when popuping', async () => {

Annotations

Check failure on line 822 in spec/api-menu-spec.ts

See this annotation in the file changed.

@trop trop / Backportable? - 24-x-y

spec/api-menu-spec.ts#L819-L822

Patch Conflict
Raw output
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue

Check failure on line 858 in spec/api-menu-spec.ts

See this annotation in the file changed.

@trop trop / Backportable? - 24-x-y

spec/api-menu-spec.ts#L855-L858

Patch Conflict
Raw output
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue

Check failure on line 822 in spec/api-menu-spec.ts

See this annotation in the file changed.

@trop trop / Backportable? - 24-x-y

spec/api-menu-spec.ts#L819-L822

Patch Conflict
Raw output
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue

Check failure on line 858 in spec/api-menu-spec.ts

See this annotation in the file changed.

@trop trop / Backportable? - 24-x-y

spec/api-menu-spec.ts#L855-L858

Patch Conflict
Raw output
++<<<<<<< HEAD
 +      // https://github.com/electron/electron/issues/19411
 +      setTimeout(() => {
 +        menu.closePopup();
 +      });
++=======
+       menu.closePopup();
++>>>>>>> test: remove workaround for fixed Menu.closePopup issue