Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply csp correctly when contextIsolation: false #37839

Merged
merged 1 commit into from Apr 5, 2023

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 5, 2023

backport of #37756.

Notes: Security: Fixed an issue with Content-Security-Policy not being correctly enforced when sandbox: false and contextIsolation: false. (CVE-2023-23623)

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2023
@trop trop bot added backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 5, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 5, 2023
@nornagon
Copy link
Member Author

nornagon commented Apr 5, 2023

/trop run backport-to 23-x-y 22-x-y

@trop
Copy link
Contributor

trop bot commented Apr 5, 2023

This PR has not been merged yet, and cannot be backported.

@nornagon nornagon added target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Apr 5, 2023
@nornagon nornagon merged commit 5517655 into 24-x-y Apr 5, 2023
12 checks passed
@nornagon nornagon deleted the backport/24-x-y/fix-csp branch April 5, 2023 19:11
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2023

Release Notes Persisted

Security: Fixed an issue with Content-Security-Policy not being correctly enforced when sandbox: false and contextIsolation: false. (CVE-2023-23623)

@trop
Copy link
Contributor

trop bot commented Apr 5, 2023

I have automatically backported this PR to "22-x-y", please check out #37843

@trop
Copy link
Contributor

trop bot commented Apr 5, 2023

I have automatically backported this PR to "23-x-y", please check out #37844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24-x-y backport This is a backport PR security 🔒 semver/patch backwards-compatible bug fixes target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants