fix: apply csp correctly when contextIsolation: false #37756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
added
security 🔒
target/22-x-y
MarshallOfSound
approved these changes
Mar 29, 2023
codebytere
approved these changes
Mar 30, 2023
zcbenz
approved these changes
Apr 4, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "22-x-y" cleanly; |
trop
bot
added
needs-manual-bp/22-x-y
and removed
target/22-x-y
|
I was unable to backport this PR to "23-x-y" cleanly; |
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/23-x-y
needs-manual-bp/24-x-y
and removed
target/23-x-y
trop
bot
added
in-flight/24-x-y
merged/24-x-y
This was referenced Apr 5, 2023
trop
bot
added
in-flight/22-x-y
merged/23-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When sandbox: false and contextIsolation: false, CSP wasn't being correctly
enforced.
Checklist
npm testpassesRelease Notes
Notes: Security: Fixed an issue with Content-Security-Policy not being correctly enforced when sandbox: false and contextIsolation: false. (CVE-2023-23623)