Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in utilityProcess when generating code from strings #38014

Merged
merged 1 commit into from Apr 20, 2023

Conversation

deepak1556
Copy link
Member

Description of Change

Regressed with #37756

New check introduced in the above PR will default to blink path for code generation in the utility process which is invalid.

Release Notes

Notes: Fix crash when executing eval in the utility process.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 18, 2023
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Apr 18, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 19, 2023
@deepak1556 deepak1556 merged commit 0240f66 into main Apr 20, 2023
18 checks passed
@deepak1556 deepak1556 deleted the robo/fix_utility_crash branch April 20, 2023 00:27
@release-clerk
Copy link

release-clerk bot commented Apr 20, 2023

Release Notes Persisted

Fix crash when executing eval in the utility process.

@trop
Copy link
Contributor

trop bot commented Apr 20, 2023

I was unable to backport this PR to "22-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/22-x-y PR should also be added to the "22-x-y" branch. label Apr 20, 2023
@trop
Copy link
Contributor

trop bot commented Apr 20, 2023

I have automatically backported this PR to "25-x-y", please check out #38039

@trop
Copy link
Contributor

trop bot commented Apr 20, 2023

I have automatically backported this PR to "23-x-y", please check out #38040

@trop
Copy link
Contributor

trop bot commented Apr 20, 2023

I have automatically backported this PR to "24-x-y", please check out #38041

@trop trop bot added in-flight/23-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/25-x-y labels Apr 20, 2023
@trop trop bot added merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/23-x-y labels Apr 24, 2023
@trop
Copy link
Contributor

trop bot commented May 3, 2023

@deepak1556 has manually backported this PR to "22-x-y", please check out #38156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants