Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in utilityProcess when generating code from strings #38040

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 20, 2023

Backport of #38014

See that PR for details.

Notes: Fix crash when executing eval in the utility process.

@trop trop bot requested a review from deepak1556 April 20, 2023 00:28
@trop trop bot added 23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 20, 2023
Co-authored-by: deepak1556 <hop2deep@gmail.com>
@codebytere codebytere force-pushed the trop/23-x-y-bp-fix-crash-in-utilityprocess-when-generating-code-from-strings-1681950459210 branch from 53bc8e1 to b8cbbda Compare April 23, 2023 20:20
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 4d8b9a8 into 23-x-y Apr 24, 2023
11 of 13 checks passed
@deepak1556 deepak1556 deleted the trop/23-x-y-bp-fix-crash-in-utilityprocess-when-generating-code-from-strings-1681950459210 branch April 24, 2023 04:22
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2023

Release Notes Persisted

Fix crash when executing eval in the utility process.

deepak1556 added a commit that referenced this pull request May 3, 2023
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
codebytere pushed a commit that referenced this pull request May 3, 2023
fix: crash in utilityProcess when generating code from strings (#38040)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant