Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify BrowserWindow.isVisible() logic cross-platform #38242

Merged
merged 1 commit into from May 16, 2023
Merged

fix: unify BrowserWindow.isVisible() logic cross-platform #38242

merged 1 commit into from May 16, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Some debugging recently alerted me to the fact that BrowserWindow.isVisible() incorrectly differs cross-platform. On macOS, a window only returns true for isVisible() if the window is in the foreground and not minimized. However, on Windows, a window could be minimized and yet incorrectly show as visible. This corrects that schism.

Checklist

Release Notes

Notes: Fixed an issue where BrowserWindow.isVisible() would incorrectly return true for minimized windows on Windows.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels May 10, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 10, 2023
@codebytere codebytere force-pushed the unify-window-isvisible branch 3 times, most recently from 6fb7e1d to 5278e2c Compare May 10, 2023 09:23
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 11, 2023
@codebytere
Copy link
Member Author

macOS is failing on #38312 and this PR changes only Windows - merging.

@codebytere codebytere merged commit e831976 into main May 16, 2023
16 of 17 checks passed
@codebytere codebytere deleted the unify-window-isvisible branch May 16, 2023 09:46
@release-clerk
Copy link

release-clerk bot commented May 16, 2023

Release Notes Persisted

Fixed an issue where BrowserWindow.isVisible() would incorrectly return true for minimized windows on Windows.

This was referenced May 16, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "24-x-y", please check out #38313

@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "25-x-y", please check out #38314

@trop
Copy link
Contributor

trop bot commented May 16, 2023

I have automatically backported this PR to "23-x-y", please check out #38315

@trop trop bot added in-flight/25-x-y in-flight/23-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/25-x-y in-flight/24-x-y labels May 16, 2023
@commit-lint commit-lint bot mentioned this pull request Aug 1, 2023
Open
@samuelmaddock samuelmaddock mentioned this pull request Jan 16, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @dsanders11