Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify BrowserWindow.isVisible() logic cross-platform #38313

Merged
merged 1 commit into from May 16, 2023
Merged

fix: unify BrowserWindow.isVisible() logic cross-platform #38313

merged 1 commit into from May 16, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 16, 2023

Backport of #38242

See that PR for details.

Notes: Fixed an issue where BrowserWindow.isVisible() would incorrectly return true for minimized windows on Windows.

@trop trop bot requested a review from codebytere May 16, 2023 09:47
@trop trop bot mentioned this pull request May 16, 2023
Merged
5 tasks
@trop trop bot added 24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 16, 2023
@codebytere codebytere force-pushed the trop/24-x-y-bp-fix-unify-browserwindow-isvisible-logic-cross-platform-1684230426742 branch from d8efc82 to 15dfd94 Compare May 16, 2023 12:28
@trop @codebytere
fix: unify BrowserWindow.isVisible() logic cross-platform
a05cfbe 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/24-x-y-bp-fix-unify-browserwindow-isvisible-logic-cross-platform-1684230426742 branch from 15dfd94 to a05cfbe Compare May 16, 2023 12:56
@jkleinsc jkleinsc merged commit 9cf44a0 into 24-x-y May 16, 2023
13 checks passed
@jkleinsc jkleinsc deleted the trop/24-x-y-bp-fix-unify-browserwindow-isvisible-logic-cross-platform-1684230426742 branch May 16, 2023 15:16
@release-clerk
Copy link

release-clerk bot commented May 16, 2023

Release Notes Persisted

Fixed an issue where BrowserWindow.isVisible() would incorrectly return true for minimized windows on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere