Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: asar integration for require('node:child_process') #38742
fix: asar integration for require('node:child_process') #38742
Changes from all commits
74b192fFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1265 in spec/asar-spec.ts
spec/asar-spec.ts#L1225-L1265
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')Check failure on line 1265 in spec/asar-spec.ts
spec/asar-spec.ts#L1225-L1265
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')Check failure on line 1268 in spec/asar-spec.ts
spec/asar-spec.ts#L1228-L1268
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')Check failure on line 1268 in spec/asar-spec.ts
spec/asar-spec.ts#L1228-L1268
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')Check failure on line 1268 in spec/asar-spec.ts
spec/asar-spec.ts#L1228-L1268
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')Check failure on line 1268 in spec/asar-spec.ts
spec/asar-spec.ts#L1228-L1268
Raw output
++<<<<<<< HEAD + ifdescribe(features.isRunAsNodeEnabled())('child_process.fork', function () { + itremote('opens a normal js file', async function () { + const child = require('child_process').fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }); + + itremote('supports asar in the forked js', async function (fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require('child_process').fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [fixtures]); + }); + + describe('child_process.exec', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require('child_process').exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + describe('child_process.execSync', function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require('child_process').execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')('child_process.execFile', function () { + itremote('executes binaries', async function () { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require('child_process').execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }); ++======= + function generateSpecs (childProcess: string) { + describe(`${childProcess}.fork`, function () { + itremote('opens a normal js file', async function (childProcess: string) { + const child = require(childProcess).fork(path.join(asarDir, 'a.asar', 'ping.js')); + child.send('message'); + const msg = await new Promise(resolve => child.once('message', resolve)); + expect(msg).to.equal('message'); + }, [childProcess]); + + itremote('supports asar in the forked js', async function (childProcess: string, fixtures: string) { + const file = path.join(asarDir, 'a.asar', 'file1'); + const child = require(childProcess).fork(path.join(fixtures, 'module', 'asar.js')); + child.send(file); + const content = await new Promise(resolve => child.once('message', resolve)); + expect(content).to.equal(fs.readFileSync(file).toString()); + }, [childProcess, fixtures]); + }); + + describe(`${childProcess}.exec`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = await promisify(require(childProcess).exec)('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + describe(`${childProcess}.execSync`, function () { + itremote('should not try to extract the command if there is a reference to a file inside an .asar', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + + const stdout = require(childProcess).execSync('echo ' + echo + ' foo bar'); + expect(stdout.toString().replace(/\r/g, '')).to.equal(echo + ' foo bar\n'); + }, [childProcess]); + }); + + ifdescribe(process.platform === 'darwin' && process.arch !== 'arm64')(`${childProcess}.execFile`, function () { + itremote('executes binaries', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const stdout = await promisify(require(childProcess).execFile)(echo, ['test']); + expect(stdout).to.equal('test\n'); + }, [childProcess]); + + itremote('executes binaries without callback', async function (childProcess: string) { + const echo = path.join(asarDir, 'echo.asar', 'echo'); + const process = require(childProcess).execFile(echo, ['test']); + const code = await new Promise(resolve => process.once('close', resolve)); + expect(code).to.equal(0); + process.on('error', function () { + throw new Error('error'); + }); + }, [childProcess]); ++>>>>>>> fix: asar integration for require('node:child_process')