Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asar integration for require('node:child_process') #38742

Merged
merged 1 commit into from Jun 14, 2023
Merged

fix: asar integration for require('node:child_process') #38742

merged 1 commit into from Jun 14, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 12, 2023 •
edited

Description of Change

Follow-up to #38567

Checklist

Release Notes

Notes: Fixed asar integration for node:child_process imports.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2023
@miniak miniak self-assigned this Jun 13, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Jun 13, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2023
@miniak miniak force-pushed the miniak/asar-require-node-child_process branch from e18213e to 4288e57 Compare June 13, 2023 22:44
@miniak miniak force-pushed the miniak/asar-require-node-child_process branch from 4288e57 to 74b192f Compare June 13, 2023 23:02
@miniak miniak marked this pull request as ready for review June 13, 2023 23:10
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2023
@deepak1556 deepak1556 merged commit dc2e822 into main Jun 14, 2023
17 checks passed
@deepak1556 deepak1556 deleted the miniak/asar-require-node-child_process branch June 14, 2023 09:03
@release-clerk
Copy link

release-clerk bot commented Jun 14, 2023

Release Notes Persisted

Fixed asar integration for node:child_process imports.

@trop
Copy link
Contributor

trop bot commented Jun 14, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 14, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Jun 14, 2023
@trop
Copy link
Contributor

trop bot commented Jun 14, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y needs-manual-bp/26-x-y needs-manual-bp/24-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Jun 14, 2023
@miniak miniak mentioned this pull request Jun 14, 2023
Merged
3 tasks
miniak added a commit that referenced this pull request Jul 25, 2023
@miniak
fix: asar integration for require('node:child_process') (#38742)
acb8013
@miniak miniak mentioned this pull request Jul 25, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 25, 2023

@miniak has manually backported this PR to "26-x-y", please check out #39234

miniak added a commit that referenced this pull request Jul 25, 2023
@miniak
fix: asar integration for require('node:child_process') (#38742)
3aaaa4f
@miniak miniak mentioned this pull request Jul 25, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 25, 2023

@miniak has manually backported this PR to "25-x-y", please check out #39235

miniak added a commit that referenced this pull request Jul 25, 2023
@miniak
fix: asar integration for require('node:child_process') (#38742)
409043c
@miniak miniak mentioned this pull request Jul 25, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 25, 2023

@miniak has manually backported this PR to "24-x-y", please check out #39236

codebytere pushed a commit that referenced this pull request Jul 26, 2023
@miniak
fix: asar integration for require('node:child_process') (#39236)
ccca1cf 
fix: asar integration for require('node:child_process') (#38742)
@trop trop bot added merged/24-x-y PR was merged to the "24-x-y" branch and removed in-flight/25-x-y labels Jul 26, 2023
codebytere pushed a commit that referenced this pull request Jul 26, 2023
@miniak
fix: asar integration for require('node:child_process') (#39235)
eccc08e 
fix: asar integration for require('node:child_process') (#38742)
@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. and removed in-flight/26-x-y labels Jul 26, 2023
codebytere pushed a commit that referenced this pull request Jul 26, 2023
@miniak
fix: asar integration for require('node:child_process') (#39234)
9ee4cb4 
fix: asar integration for require('node:child_process') (#38742)
@trop trop bot added the merged/26-x-y PR was merged to the "26-x-y" branch. label Jul 26, 2023
@commit-lint commit-lint bot mentioned this pull request Sep 5, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
fix: asar integration for require('node:child_process') (electron#38742)
9557ba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @deepak1556