fix: ensure BrowserView bounds are always relative to window
#39605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
requested review from
jkleinsc,
deepak1556,
miniak and
MarshallOfSound
codebytere
added
target/25-x-y
codebytere
force-pushed
the
coordinate-space-calculation-change
branch
from
fd8cf86
to
be77505
Compare
VerteDinde
approved these changes
Aug 22, 2023
MarshallOfSound
approved these changes
Aug 22, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "25-x-y" cleanly; |
|
I was unable to backport this PR to "26-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
needs-manual-bp/26-x-y
and removed
target/25-x-y
|
I have automatically backported this PR to "27-x-y", please check out #39627 |
trop
bot
added
in-flight/27-x-y
merged/27-x-y
|
@codebytere has manually backported this PR to "26-x-y", please check out #39850 |
|
@codebytere has manually backported this PR to "25-x-y", please check out #39851 |
trop
bot
added
in-flight/25-x-y
merged/25-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…ron#39605) fix: ensure BrowserView bounds are always relative to window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39257
Fixes an issue where
BrowserViewsthat have their bounds set prior to being added to aBrowserWindowhave unexpected incorrect offsets after being added. This was happening becauseBrowserViewbounds are intended to be relative to the containing window, and were not updated relative to the window once they were added to one. We fix this by checking whether or not theBrowserViewhad its bounds previously set and ensure they're reset relative to the window on addition.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
BrowserViewsthat had their bounds set prior to being added to aBrowserWindowcould have unexpected incorrect offsets.