Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure BrowserView bounds are always relative to window #39851

Merged
merged 1 commit into from Sep 14, 2023
Merged

fix: ensure BrowserView bounds are always relative to window #39851

merged 1 commit into from Sep 14, 2023

Conversation

codebytere
Copy link
Member

Backport of #39605.

See that PR for details.

Notes: Fixed an issue where BrowserViews that had their bounds set prior to being added to a BrowserWindow could have unexpected incorrect offsets.

@codebytere codebytere requested a review from a team September 13, 2023 16:12
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 13, 2023
@trop trop bot mentioned this pull request Sep 13, 2023
Merged
4 tasks
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 13, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 13, 2023
@jkleinsc jkleinsc merged commit aa799e2 into 25-x-y Sep 14, 2023
13 checks passed
@jkleinsc jkleinsc deleted the coordinate-space-calculation-change-25 branch September 14, 2023 14:38
@release-clerk
Copy link

release-clerk bot commented Sep 14, 2023

Release Notes Persisted

Fixed an issue where BrowserViews that had their bounds set prior to being added to a BrowserWindow could have unexpected incorrect offsets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc