-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: frameless mica/acrylic windows #39708
Conversation
with translucent background materials to become activated. | ||
|
||
This patch likely can't be upstreamed as-is, as Chromium doesn't have | ||
this use case in mind currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for a simple patch like this there is a chance upstreaming it, read the change log of the file and find the maintainer who has done related modifications, and ask them to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on Windows - the transparency seems to be working as expected. I'm also fine merging this as is and potentially upstreaming the patch later
Release Notes Persisted
|
I have automatically backported this PR to "27-x-y", please check out #39802 |
Great, I hope to merge into Electron 26 soon. |
* fix: backgroundMaterial works with frameless * TODO: fix frameless mica/acrylic windows * update caption color appropriately * set background color properly * refactor translucency method * actualization
Description of Change
Fixes #38532
Checklist
npm test
passesRelease Notes
Notes: Fixed Windows Mica/Acrylic background material effects on frameless windows.