fix: remove EarlyMallocZoneRegistration call #40128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No Release Notes |
5 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR reverts #33832 for 2 reasons:
EarlyMallocZoneRegistrationcall is currently a no-op since PartitionAlloc is disabled in Electron.EarlyMallocZoneRegistrationis that the whole application is built as a library and the executable binary loads the app bydlopenanddlsym(https://bugs.chromium.org/p/chromium/issues/detail?id=1452229 has some background information on this). Electron is currently still linking the executable binaries to theElectron Frameworkwhich does not match the prerequisite and will crash when PartitionAlloc is enabled.This PR will unblock #33981.
Release Notes
Notes: none