build: re-enable partition alloc on mac #33981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test would be a side-effect of #33832, needs further investigation. |
5 tasks
VerteDinde
force-pushed
the
reenable-partition-alloc
branch
from
aed872b
to
3b25115
Compare
miniak
added
target/21-x-y
jkleinsc
added
target/25-x-y
github-actions
bot
added
the
target/26-x-y
github-actions
bot
added
the
target/27-x-y
|
@VerteDinde With #40128 I think this PR should be ready to go, can you rebase it on main? |
|
Also changing memory allocator is a bit dangerous and can potentially break things, I think we should at least not backport this change to stable branches. |
miniak
removed
target/23-x-y
zcbenz
added
no-backport
target/28-x-y
zcbenz
approved these changes
Oct 16, 2023
zcbenz
added
semver/patch
deepak1556
approved these changes
Oct 17, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "28-x-y", please check out #40230 |
trop
bot
added
in-flight/28-x-y
merged/28-x-y
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
chase
added a commit
to coparse-inc/electron-libreoffice
that referenced
this pull request
Oct 27, 2023
There are several cases we've encountered where allocs and frees don't match the correct allocator when going from Electron to LibreOfficeKit, causing crashes. Usually an allocaiton is preformed in LOK with the system default allocator but then Electron tries to free it with the partition allocator. This is already disabled on macOS by default so disabling it for Windows and Linux doesn't really change much. They only just re-enabled partition alloc on Mac last week anyway: electron/electron#33981
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#33704 fixed a partition alloc-related crash in MacOS versions <= 10.15. With that crash fixed, we should be able to re-enable partition alloc!
This PR re-enables partition alloc on MacOS by removing the Chromium patch.
Checklist
npm testpassesRelease Notes
Notes: Re-enabled partition alloc on Mac