New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: undici incorrectly copies headers onto fetches #41019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, that's a big cherry-pick 🍒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch fails to apply
@jkleinsc i got some weird CRLF errors in console initially - i think it might be related. I'll check it out - it applied locally and i didn't make it too hackily so idk what else it could be 🤔 |
04784dc
to
a012ad2
Compare
a012ad2
to
4de493a
Compare
Release Notes Persisted
|
I have automatically backported this PR to "28-x-y", please check out #41103 |
Description of Change
Closes #41005.
Refs nodejs/node#50153
Refs nodejs/undici#2359
Fixes an issue where undici in migrating build scripts accidentally regressed constructor name exports.
This is fixed in Node.js v20.10.0 and beyond by nodejs/node#50274 but as that PR is very large, this cherry-picks out just the fix for the constructor issue by running the build script with the missing
keepNames
argument and copying the resultingundici-fetch.js
output todeps/undici/undici.js
, as Node.js themselves do in their update scriptChecklist
npm test
passesRelease Notes
Notes: Fixes an issue where Request objects did not correctly copy headers into fetches.