Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undici incorrectly copies headers onto fetches #41103

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 24, 2024

Backport of #41019

See that PR for details.

Notes: Fixes an issue where Request objects did not correctly copy headers into fetches.

@trop trop bot requested a review from a team as a code owner January 24, 2024 16:33
@trop trop bot requested a review from codebytere January 24, 2024 16:33
@trop trop bot added 28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 24, 2024
Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com>
@jkleinsc jkleinsc force-pushed the trop/28-x-y-bp-fix-undici-incorrectly-copies-headers-onto-fetches-1706113978100 branch from 96bb6c4 to 631e8b7 Compare January 25, 2024 20:39
@codebytere
Copy link
Member

Failing test:

BrowserWindow module focus and visibility BrowserWindow.focus() it does not activate the app if focusing an inactive panel

not related and present/flaky in other PRs.

@codebytere codebytere merged commit 750df6a into 28-x-y Jan 28, 2024
12 of 13 checks passed
@codebytere codebytere deleted the trop/28-x-y-bp-fix-undici-incorrectly-copies-headers-onto-fetches-1706113978100 branch January 28, 2024 19:40
Copy link

release-clerk bot commented Jan 28, 2024

Release Notes Persisted

Fixes an issue where Request objects did not correctly copy headers into fetches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant