Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

fix: expose libgtkui::GetFgColor (backport: 3-1-x) #742

Conversation

Cobinja
Copy link

@Cobinja Cobinja commented Dec 31, 2018

Description of Change

Backport libcc portion of electron/electron#15878 to 3-1-x
/cc @inukshuk

Checklist
  • PR description included and stakeholders cc'd
  • Patch information is added to appropriate .patches.yaml
  • script/update runs without error
  • PR title follows semantic commit guidelines
Notes

srcipt/updateruns into the (probably) same error as in #690 (comment)
The patch file actually gets applied, but the script tells otherwise

@codebytere
Copy link
Member

hey @Cobinja this patch doesn't apply due to mismatched line numbers; you'll need to ensure it applies locally with script/update. We can get this merged once that's fixed up!

@Cobinja Cobinja force-pushed the backport-fix-export-GetFgColor-3-1-x branch from 8eed2cc to 4b34d29 Compare January 2, 2019 19:43
@Cobinja
Copy link
Author

Cobinja commented Jan 2, 2019

@codebytere I forced-pushed a new version. It wasn't the line numbers you suspected. I can't tell what it actually was but I suspect a confusion of line-ending types

@codebytere codebytere merged commit 01b1896 into electron:electron-3-1-x Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants