Moved hostArch() earlier in validateListFromOptions() #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This PR is in response to atom/atom#15431. When I tried to build Atom on my Chromebook running Arch Linux ARM, the automatic trigger detecting armv7l was not running because a value already existed for the arch. This change moves the hostArch() function before the list assignment to catch this case.
I did not add documentation for this change because it is sufficiently simple that I think additional comments would not be helpful. Similarly, I did not add tests. I confess I don't know how to run the test suite, but the code did pass one important test -- when I ran it, the correct architecture was detected and
a package was built!