Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved hostArch() earlier in validateListFromOptions() #775

Closed
wants to merge 1 commit into from

Conversation

mathuin
Copy link

@mathuin mathuin commented Dec 12, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR is in response to atom/atom#15431. When I tried to build Atom on my Chromebook running Arch Linux ARM, the automatic trigger detecting armv7l was not running because a value already existed for the arch. This change moves the hostArch() function before the list assignment to catch this case.

I did not add documentation for this change because it is sufficiently simple that I think additional comments would not be helpful. Similarly, I did not add tests. I confess I don't know how to run the test suite, but the code did pass one important test -- when I ran it, the correct architecture was detected and
a package was built!

This PR is in response to atom/atom#15431.  When I tried to build Atom
on my Chromebook running Arch Linux ARM, the automatic trigger detecting
armv7l was not running because a value already existed for the arch.

This change moves the hostArch() function before the list assignment to
catch this case.  When I run this code on my Chromebook, the packaging
code appears to succeed.
@welcome
Copy link

welcome bot commented Dec 12, 2017

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@malept
Copy link
Member

malept commented Dec 18, 2017

The big problem with this solution is that the tests fail. Frankly, I'm not sure it's the correct solution.

@mathuin
Copy link
Author

mathuin commented Dec 18, 2017

That's fine -- the intent was to share with you the code that ran on my system in the hopes that you would be able to make a proper patch. Like I mentioned in the other issue, I don't know the language and certainly don't understand the codebase. It's okay if you want to close the PR -- I just wanted you to see the code that worked here.

@malept
Copy link
Member

malept commented Dec 23, 2017

I'm going to close this due to the rationale I laid out in atom/atom#15431 (comment) - in the near future, I'll add explicit unit tests for hostArch() and validateListFromOptions() regarding armv7l detection.

@malept malept closed this Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants