Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved hostArch() earlier in validateListFromOptions() #775

Closed
wants to merge 1 commit into from
Closed

Moved hostArch() earlier in validateListFromOptions() #775

wants to merge 1 commit into from

Commits on Dec 12, 2017

  1. Moved hostArch() earlier in validateListFromOptions() 

    This PR is in response to atom/atom#15431.  When I tried to build Atom
on my Chromebook running Arch Linux ARM, the automatic trigger detecting
armv7l was not running because a value already existed for the arch.

This change moves the hostArch() function before the list assignment to
catch this case.  When I run this code on my Chromebook, the packaging
code appears to succeed.
    @mathuin
    mathuin committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    87b5e50 View commit details
    Browse the repository at this point in the history