fix(components): fix iOS select click event listening #16393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS Safari does not handle click events when a mouseenter event is registered and a DOM-change happens in a child. We use a Vue custom event binding to only register the event on non-iOS devices. The inputHovering state gets updated now on iOS-devices on click. This is needed as the mouseenter event normally does this. closed element-plus#5210
|
👋 @raphaelbernhart, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @raphaelbernhart, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
🧪 Playground Preview: https://element-plus.run/?pr=16393 |
|
@kooriookami @tolking Do you have relevant device verification? |
No, I have no IOS device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / fix
iOS Safari does not handle click events when a mouseenter event is registered and a DOM-change happens in a child.
We use a Vue custom event binding to only register the event on non-iOS devices.
The inputHovering state gets updated now on iOS-devices on click. This is needed as the mouseenter event normally does this.
Apple Developer Documentation: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html
Vue Issue: vuejs/vue#9859
Here are some test-case recordings
Before changes
Screen.Recording.2024-04-04.at.11.07.08.mov
After changes
Screen.Recording.2024-04-04.at.11.09.15.mov
closed #5210