Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix iOS select click event listening #16393

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(components): fix iOS select click event listening #16393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/select/src/select.vue
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
ref="selectRef"
v-click-outside:[popperRef]="handleClickOutside"
:class="[nsSelect.b(), nsSelect.m(selectSize)]"
@mouseenter="states.inputHovering = true"
@[mouseEnterEventName]="states.inputHovering = true"
@mouseleave="states.inputHovering = false"
@click.prevent.stop="toggleMenu"
>
Expand Down
12 changes: 12 additions & 0 deletions packages/components/select/src/useSelect.ts
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@ import {
debugWarn,
isClient,
isFunction,
isIOS,
isNumber,
isUndefined,
scrollIntoView,
Expand Down Expand Up @@ -253,6 +254,12 @@ export const useSelect = (props: ISelectProps, emit) => {
: states.selectedLabel
})

// iOS Safari does not handle click events when a mouseenter event is registered and a DOM-change happens in a child
// We use a Vue custom event binding to only register the event on non-iOS devices
// ref.: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/HandlingEvents/HandlingEvents.html
// Github Issue: https://github.com/vuejs/vue/issues/9859
const mouseEnterEventName = computed(() => (isIOS ? null : 'mouseenter'))

watch(
() => props.modelValue,
(val, oldVal) => {
Expand Down Expand Up @@ -670,6 +677,10 @@ export const useSelect = (props: ISelectProps, emit) => {
const toggleMenu = () => {
if (selectDisabled.value) return

// We only set the inputHovering state to true on mouseenter event on iOS devices
// To keep the state updated we set it here to true
if (isIOS) states.inputHovering = true

if (states.menuVisibleOnFocus) {
// controlled by automaticDropdown
states.menuVisibleOnFocus = false
Expand Down Expand Up @@ -814,6 +825,7 @@ export const useSelect = (props: ISelectProps, emit) => {
hasModelValue,
shouldShowPlaceholder,
currentPlaceholder,
mouseEnterEventName,
showClose,
iconComponent,
iconReverse,
Expand Down