Handle relative paths when fixing keys #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a mono repo with v2-style in-repo addons and tests. For instance, we have
ROOT/addons/internal
andROOT/tests/internal
. The path relative to our tests end up looking like../../addons/internal
. Without the new conditional, we'd end up hitting the fallback case which tries to make everything relative totests/internal/app
this would end up getting translated intoROOT/tests/addons/internal
which is not the correct path. I believe it should always be correct to pass relative paths through as-is, which is what I've done here. This solves the problem for our uses.