Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for npm v4 #964

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Drop support for npm v4 #964

merged 2 commits into from
Sep 6, 2023

Conversation

bertdeblock
Copy link

@bertdeblock bertdeblock commented Sep 5, 2023 •
edited

Closes #961.

@bertdeblock bertdeblock marked this pull request as ready for review September 5, 2023 19:44
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited

Codecov Report

Merging #964 (f634800) into master (b0f477b) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head f634800 differs from pull request most recent head 80587e6. Consider uploading reports for the commit 80587e6 to get more accurate results

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   94.53%   94.38%   -0.16%     
==========================================
  Files          17       17              
  Lines         549      534      -15     
==========================================
- Hits          519      504      -15     
  Misses         30       30
Files Changed Coverage Δ
lib/dependency-manager-adapters/npm.js 98.09% <100.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bertdeblock bertdeblock marked this pull request as draft September 5, 2023 19:56
@bertdeblock
Copy link
Author

@kategengler @mansona Should I just remove the use of --no-shrinkwrap in this PR as well?

@mansona
Copy link
Member

mansona commented Sep 5, 2023 •
edited

@bertdeblock yes I would say so 👍 and when you do you can close #961 👍

@bertdeblock bertdeblock marked this pull request as ready for review September 6, 2023 05:39
@bertdeblock bertdeblock mentioned this pull request Sep 6, 2023
Merged
mansona
mansona approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@bertdeblock bertdeblock merged commit f68085c into ember-cli:master Sep 6, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kategengler kategengler kategengler approved these changes

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bertdeblock @mansona @kategengler