Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with default computed property import in no-unused-services rule #1870

Merged

Conversation

bmish
Copy link
Member

@bmish bmish commented May 21, 2023

Crash detected by:

Rule: "ember/no-unused-services"
Path: emberjs/data/@types/@ember/array/-private/enumerable.d.ts
Link: https://github.com/emberjs/data/blob/HEAD/@types/@ember/array/-private/enumerable.d.ts#L2

  1 | import type NativeArray from '@ember/array/-private/native-array';
> 2 | import type ComputedProperty from '@ember/object/computed';
  3 | import type Mixin from '@ember/object/mixin';
  4 | /**
  5 |  * This mixin defines the common interface implemented by enumerable objects

Error:
TypeError: Cannot read property 'name' of undefined
Occurred while linting /home/runner/work/eslint-plugin-ember/eslint-plugin-ember/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/emberjs/data/@types/@ember/array/-private/enumerable.d.ts:2
Rule: "ember/no-unused-services"
    at ImportDeclaration (/home/runner/work/eslint-plugin-ember/eslint-plugin-ember/lib/rules/no-unused-services.js:133:40)

@bmish bmish added the Bug label May 21, 2023
@bmish bmish merged commit 3f9a95f into ember-cli:master May 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant