Add autofixer to block-indentation rule

[VincentMolinie]

No description provided.

[bmish]

Hope to see this and #2271 land!

[VincentMolinie]

Hope to see this and #2271 land!

Yeah this one seems good I think. attribute-indetation needs some reqorks as I'm actually fixing block-identation inside it 😅

[VincentMolinie]

tests pass @bmish 🙌

[bmish]

Looks like you need to run yarn update:readme.

[bmish]

This is looking pretty good, thanks for working on it. I think we need a bit more high-level commenting to help people follow what's going on since the logic is a bit complex.

[bmish]

This looks wrong?

[VincentMolinie]

That's the purpose. It says Bad example but It's actually a good one 😅

[bmish]

Better way to write this is: node.body.length > 0

[VincentMolinie]

Like I said thé indentation of block start IS validated only for thé first node while It should validated all. This code disappear if WE want to really fix this issue

[bmish]

This is looking pretty good, thanks for working on it. I think we need a bit more high-level commenting, maybe some clearer naming to help people follow what's going on since the logic is a bit complex.

[VincentMolinie]

There is an issue on thé Indent. I did a fix at first but rollbacked It cause I didn't know if I should do It in this PR.
This code IS considered valid :

<div>
</div>
  <span>
  </span>

The fix of thé rule and thé autofix are quitté easy, let me know if you want It in this PR

[bmish]

There is an issue on thé Indent. I did a fix at first but rollbacked It cause I didn't know if I should do It in this PR. This code IS considered valid :

<div>
</div>
  <span>
  </span>

The fix of thé rule and thé autofix are quitté easy, let me know if you want It in this PR

@VincentMolinie it should be fine for us to fix the bug as a follow-up PR. Thanks for working on this!

[VincentMolinie]

There is an issue on thé Indent. I did a fix at first but rollbacked It cause I didn't know if I should do It in this PR. This code IS considered valid :

<div>
</div>
  <span>
  </span>

The fix of thé rule and thé autofix are quitté easy, let me know if you want It in this PR

@VincentMolinie it should be fine for us to fix the bug as a follow-up PR. Thanks for working on this!

Okey so you want me to rollback: 0e20e0c ?

[bmish]

@VincentMolinie would it be easy for you to extract that bug fix to a follow-up PR? If so, let's do that quickly. If too inconvenient, we can keep them together.

[VincentMolinie]

Done ✅ @bmish

[bmish]

@VincentMolinie thanks, did you see the above comment about the bug extraction? Just wondering what you think.

[VincentMolinie]

Yes I removed the commit 😉 and I will create a PR once this one is merged ^^

[bmish]

Thank you!

[bmish]

@VincentMolinie excellent, can you create that other PR now?

[VincentMolinie]

It's right here: #2318