Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial-fix: default pods paths to false for no-this-in-template-only-components #2335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

runspired
Copy link
Contributor

helps with #2321

@bmish
Copy link
Member

bmish commented Jan 13, 2022

Can we add a rule test for this?

@elidupuis
Copy link
Contributor

@bmish Interestingly, it appears that there is a test for route templates already:

{
template: '{{my-component model=this.model}}',
meta: {
filePath: 'app/templates/route-template.hbs',
},
},

But something is missing because this rule definitely flags this.foo usage in our route templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants