Remove role requirement for img tags in require-valid-alt-text
#2828
Conversation
yannbertrand
force-pushed
the
fix-img-do-not-need-role
branch
from
63aad8a
to
24c130e
Compare
lin-ll
changed the title
img tags should not have role attributerole requirement for img tags in require-valid-alt-text
Thanks for the review. What do you mean by making the rule optional? Should I remove these lines?
Interesting! Is there a planning of these events we can find somewhere? |
|
I've added a commit to accept |
yannbertrand
force-pushed
the
fix-img-do-not-need-role
branch
from
3ee578c
to
61e2518
Compare
yannbertrand
force-pushed
the
fix-img-do-not-need-role
branch
from
61e2518
to
1418b8f
Compare
…er-template-lint#2852) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e-lint#2851) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nt#2850) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
I think the intended changes here have become more urgent with the recent aria-query updates. Now both versions of an empty alt with presentation role: $ echo '<img src="src" alt="" role="presentation">' | npx ember-template-lint --
undefined
1:0 error Use of redundant or invalid role: presentation on <img> detected. no-redundant-roleempty alt without role: $ echo '<img src="src" alt="">' | npx ember-template-lint --
undefined
1:0 error If the `alt` attribute is present and the value is an empty string, `role="presentation"` or `role="none"` must be present require-valid-alt-text |
| '<img alt="" role="none" src="zoey.jpg">', | ||
| '<img alt="" role="presentation" src="zoey.jpg">', | ||
| '<img alt="a stylized graphic of a female hamster" src="zoey.jpg">', | ||
| '<img alt="a stylized graphic of a female hamster" role="presentation" src="zoey.jpg">', |
There was a problem hiding this comment.
role="presentation" and role="none" are not valid when alt is a non-empty string
| // if the role value is a mustache statement we can not validate it | ||
| if (hasAltAttribute && hasRole && !roleValue.type) { | ||
| if ( | ||
| ['none', 'presentation'].includes(roleValue.trim().toLowerCase()) && | ||
| altValue !== '' | ||
| ) { | ||
| this.logNode({ | ||
| message: | ||
| 'The `alt` attribute should be empty if `<img>` has `role` of `none` or `presentation`', | ||
| node, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think this should be removed. It is not valid to have a non-empty alt attribute if role="presentation" or role="none".
Removing this is not necessary to remove the requirement of setting role="presentation" or role="none" and doing so allows invalid markup like <img alt="non-empty-text" role="presentation" />
|
I'm closing this in favor of #2954 |
Affects
require-valid-alt-text.roleshould never be needed when using animgtag according to the W3C Nu Validator.Closes #2190
Closes #2579.