Don't require redundant role for <img alt="" /> in require-valid-alt-text rule
#2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ember-template-lint#2951 This updates the `require-valid-alt-text` rule so that it does not *require* setting `role="presentation"` or `role="none"` for an `<img alt="" />`. Context After bumping `aria-query` in ember-template-lint#2927, `ember-template-lint` began reporting an error for the following: ```html <img alt="" role="presentation" /> ``` The error is from the `no-redundant-role`. I believe it is correct to report an error in this case because `<img alt="" />` already implicitly has a `role` of `presentation`. However, this new behavior was in direct conflict with part of the `require-valid-alt-text` rule that required setting `role="presentation"` or `role="none"` whenever an image has `alt=""`.
HeroicEric
force-pushed
the
fix-dont-require-redundant-role
branch
from
f269000
to
e413335
Compare
|
Just realized someone already started on this in #2828 🙃 I believe the fix in this branch to be more correct because #2828 (comment) |
bmish
changed the title
<img alt="" /> in require-valid-alt-text rule
|
Seems reasonable. Should we proceed with this PR? @yannbertrand @jaswilli @MelSumner |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2951,
Closes #2190,
Closes #2579,
Closes #2828
This updates the
require-valid-alt-textrule so that it does not require settingrole="presentation"orrole="none"for an<img alt="" />.Context
After bumping
aria-queryin #2927,ember-template-lintbegan reporting an error for the following:The error is from the
no-redundant-role. I believe it is correct to report an error in this case because<img alt="" />already implicitly has aroleofpresentation.However, this new behavior was in direct conflict with part of the
require-valid-alt-textrule that required settingrole="presentation"orrole="none"whenever an image hasalt="". It is valid to set one of these roles but it should not be required. Removing this requirement allows these two rules (no-redundant-roleandrequire-valid-alt-text) to continue to be used together.