Disable no-curly-component-invocation and no-implicit-this rules for gjs / gts files
#2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template-lint#2830 Normally this would be a breaking change under any other circumstances, but gjs/gts folks need to disable these rules anyway, so this is more a bugfix.
bmish
changed the title
no-curly-component-invocation and no-implicit-this rules for gjs / gts files
bmish
reviewed
Mar 15, 2023
Comment on lines
+98
to
+99
| 'no-curly-component-invocation': 'off', | ||
| 'no-implicit-this': 'off', |
There was a problem hiding this comment.
Mind adding a comment next to each of these rules explaining why they are disabled for gjs/gts?
There was a problem hiding this comment.
that's what I get for trying to do this all in-browser 🙃
bmish
changed the title
no-curly-component-invocation and no-implicit-this rules for gjs / gts filesno-curly-component-invocation and no-implicit-this rules for gjs / gts files (#2844)Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
bmish
changed the title
no-curly-component-invocation and no-implicit-this rules for gjs / gts files (#2844)Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>no-curly-component-invocation and no-implicit-this rules for gjs / gts files
1 task
|
For some strange reason I'm still having to override this in an app using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2830
Normally this would be a breaking change under any other circumstances, but gjs/gts folks need to disable these rules anyway, so this is more a bugfix.